Update to svelte 5 #12364
Draft
Update to svelte 5 #12364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: svelte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
@astrojs/svelteintegration to use Svelte 5 by default. This change is necessary because the Svelte 5 Vite plugin only supports Svelte 5 and has dropped all v4 support. So it'd be really messy supporting both versions in one integration. We'd be better off cutting a new major and only supporting v5 on the new major and beyond.Removes all Svelte 4 code and deps from the integration.
Fixes or updates all the tests to use Svelte 5 components.
Testing
All the unit tests have been updated to use the newer Svelte 5 syntax, all the fixtures have also been updated to use Svelte 5 as a dependency. Running the fixtures shows the integration works and loads up Svelte 5 components.
Docs
I... Should add some docs for this yes. This will be a pretty big change(? or a reasonably sized one I guess) as we'll now stick Svelte 4 on a certain major of the package, and carrying on will only be Svelte 5 support.